Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Masthead: Use inverse components styles from govuk-frontend v5.0.0 and adjust spacing #134

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

paulrobertlloyd
Copy link
Contributor

@paulrobertlloyd paulrobertlloyd commented Jul 6, 2023

govuk-frontend v4.7.0 introduced inverse modifiers for buttons, breadcrumbs and back links, specifically due to use cases like that used by the Masthead component.

This means we can remove our own modifiers. Of note:

  1. We still need additional adaptions for the breadcrumb and phase banner when they sit within this component (see Consider adding a bottom-border modifier for breadcrumbs alphagov/govuk-frontend#3914)

  2. The govuk-frontend inverse button component specifies govuk-colour("blue") for the button text, not govuk-brand-colour.

    That might be the right decision so opening it up to discussion as to whether to stick to that within the previous behaviour (which requires overrides), or changing to use blue text. The MoD design system, as one example, also uses the brand colour for button text within the masthead).

    Update 27 July 2023: This issue is being addressed in Improvements to inverse components alphagov/govuk-frontend#3925

@paulrobertlloyd
Copy link
Contributor Author

@paulrobertlloyd paulrobertlloyd marked this pull request as draft July 27, 2023 12:03
@paulrobertlloyd paulrobertlloyd force-pushed the govuk-frontend-inverse branch 2 times, most recently from bf80f04 to 34e6692 Compare July 27, 2023 13:47
@paulrobertlloyd paulrobertlloyd changed the title Use inverse button and breadcrumb styles from govuk-frontend v4.7.0 Use inverse button and breadcrumb styles from govuk-frontend v5.0.0 Dec 8, 2023
@paulrobertlloyd paulrobertlloyd added this to the v3.0 milestone Dec 18, 2023
@paulrobertlloyd paulrobertlloyd force-pushed the govuk-frontend-inverse branch 2 times, most recently from 802082d to a17284e Compare December 19, 2023 19:28
@paulrobertlloyd paulrobertlloyd changed the title Use inverse button and breadcrumb styles from govuk-frontend v5.0.0 Masthead: Use inverse components styles from govuk-frontend v5.0.0 and adjust spacing Dec 19, 2023
- Use inverse styles now provided by govuk-frontend
- Use larger fonts by default and remove --large modifier
- Apply margins in the same direction
- Do less modification of child elements
@paulrobertlloyd
Copy link
Contributor Author

Component revised such that:

  • Use inverse styles now provided by govuk-frontend
  • Use larger fonts by default and remove --large modifier
  • Apply margins in the same direction
  • Do less modification of child elements

These changes mean the design more closely aligns with both masthead on product pages, and also the topic pages used on GOV.UK.

@paulrobertlloyd paulrobertlloyd marked this pull request as ready for review December 19, 2023 19:33
@paulrobertlloyd paulrobertlloyd merged commit 136b431 into main Dec 19, 2023
2 checks passed
@paulrobertlloyd paulrobertlloyd deleted the govuk-frontend-inverse branch December 19, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant