Masthead: Use inverse components styles from govuk-frontend
v5.0.0 and adjust spacing
#134
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
govuk-frontend
v4.7.0 introduced inverse modifiers for buttons, breadcrumbs and back links, specifically due to use cases like that used by the Masthead component.This means we can remove our own modifiers. Of note:
We still need additional adaptions for the breadcrumb and phase banner when they sit within this component (see Consider adding a bottom-border modifier for breadcrumbs alphagov/govuk-frontend#3914)
The
govuk-frontend
inverse button component specifiesgovuk-colour("blue")
for the button text, notgovuk-brand-colour
.That might be the right decision so opening it up to discussion as to whether to stick to that within the previous behaviour (which requires overrides), or changing to use blue text. The MoD design system, as one example, also uses the brand colour for button text within the masthead).