-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove primary navigation component #246
Conversation
paulrobertlloyd
commented
Aug 30, 2024
- Remove primary navigation component
- Remove documentation for primary navigation component, but keep page with a link to Service navigation on GOV.UK Design System website
- Remove examples for the primary navigation component
- Update remaining documentation and examples to use Service navigation component, where relevant
- Bump package to v4.0.0, a breaking MAJOR release
@@ -51,7 +51,7 @@ | |||
"@11ty/eleventy": "^2.0.1", | |||
"@rollup/plugin-commonjs": "^26.0.0", | |||
"@rollup/plugin-node-resolve": "^15.0.1", | |||
"@x-govuk/govuk-eleventy-plugin": "^6.0.0", | |||
"@x-govuk/govuk-eleventy-plugin": "x-govuk/govuk-eleventy-plugin#service-navigation", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Depends on x-govuk/govuk-eleventy-plugin#316
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should do a slightly less aggressive deprecation strategy, by keeping the page in the nav, and keeping the previous examples and documentation, but having the "this has been retired" banner at the top, and making it clear that the examples below will only work in versions below 4.0.0?
Could even include a section explaining how to switch from xGovukPrimaryNavigation({ .. })
to govukServiceNavigation({ .. })
?
Feels like there might still be a need to keep the documentation around for xGovukPrimaryNavigation
for a while longer (6 months?) to give people a chance to upgrade.
Looks like around 20 public repos have used this component! https://github.com/search?q=xGovukPrimaryNavigation&type=code |
Why do you spoil all my fun @frankieroberto 🥹 So maybe we do a MINOR release, and add deprecation notices where we can. Am thinking:
Then, in version 4, remove the component as shown in this PR. I might try and achieve the above in a separate PR. |
@paulrobertlloyd that sounds reasonable to me! We could also do a bit of proactive outreach to the repos who’re using the component to warn them about the deprecation. |