Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove primary navigation component #246

Closed
wants to merge 4 commits into from

Conversation

paulrobertlloyd
Copy link
Contributor

  • Remove primary navigation component
  • Remove documentation for primary navigation component, but keep page with a link to Service navigation on GOV.UK Design System website
  • Remove examples for the primary navigation component
  • Update remaining documentation and examples to use Service navigation component, where relevant
  • Bump package to v4.0.0, a breaking MAJOR release
Screenshot of retirement notice.

@@ -51,7 +51,7 @@
"@11ty/eleventy": "^2.0.1",
"@rollup/plugin-commonjs": "^26.0.0",
"@rollup/plugin-node-resolve": "^15.0.1",
"@x-govuk/govuk-eleventy-plugin": "^6.0.0",
"@x-govuk/govuk-eleventy-plugin": "x-govuk/govuk-eleventy-plugin#service-navigation",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@frankieroberto frankieroberto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should do a slightly less aggressive deprecation strategy, by keeping the page in the nav, and keeping the previous examples and documentation, but having the "this has been retired" banner at the top, and making it clear that the examples below will only work in versions below 4.0.0?

Could even include a section explaining how to switch from xGovukPrimaryNavigation({ .. }) to govukServiceNavigation({ .. })?

Feels like there might still be a need to keep the documentation around for xGovukPrimaryNavigation for a while longer (6 months?) to give people a chance to upgrade.

@frankieroberto
Copy link
Contributor

Looks like around 20 public repos have used this component! https://github.com/search?q=xGovukPrimaryNavigation&type=code

@paulrobertlloyd
Copy link
Contributor Author

Why do you spoil all my fun @frankieroberto 🥹

So maybe we do a MINOR release, and add deprecation notices where we can. Am thinking:

  • On the docs, add the above banner
  • In SCSS, output deprecation warning to the console
  • In the Prototype Kit templates, includes a deprecation message in the meta data somewhere
  • Possibly in the Nunjucks somehow, include a filter that outputs a deprecation message to the console

Then, in version 4, remove the component as shown in this PR. I might try and achieve the above in a separate PR.

@frankieroberto
Copy link
Contributor

@paulrobertlloyd that sounds reasonable to me!

We could also do a bit of proactive outreach to the repos who’re using the component to warn them about the deprecation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants