Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support trace api spec #2

Closed
wants to merge 2 commits into from
Closed

feat: support trace api spec #2

wants to merge 2 commits into from

Conversation

clint419
Copy link

@clint419 clint419 commented Sep 7, 2023 •
edited
Loading

@clint419 clint419 mentioned this pull request Sep 7, 2023
Closed
@xJonathanLEI
Copy link
Owner

Thanks for the PR. I see you're fixing the part where there's a nested schema in the schema. I'm not sure whether this is considered invalid in OpenAPI, but in the past I always patched the spec itself instead. Let's do the same here.

@xJonathanLEI
Copy link
Owner

Looks like the patch for required is also unnecessary? Nothing in the specs seems to break that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clint419 @xJonathanLEI