fix: incorrect upper bound for s in sign (#486)

xJonathanLEI · Oct 29, 2023 · 1dc8be2 · 1dc8be2
1 parent 696dd28
commit 1dc8be2
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/starknet-crypto/src/ecdsa.rs b/starknet-crypto/src/ecdsa.rs
@@ -108,7 +108,7 @@ pub fn sign(
     let s = mul_mod_floor(&r, private_key, &EC_ORDER);
     let s = add_unbounded(&s, message);
     let s = bigint_mul_mod_floor(s, &k_inv, &EC_ORDER);
-    if s == FieldElement::ZERO || s >= EC_ORDER {
+    if s == FieldElement::ZERO || s >= ELEMENT_UPPER_BOUND {
         return Err(SignError::InvalidK);
     }