-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: de/serialize based on human readability #532
Conversation
This PR is all good by itself. I wanted to merge it, but it this is an unfortunately timing to introduce a breaking change as we're migrating to the official |
Understandable! It's not urgent for now so I don't mind the delay 👍. |
fa83157
to
d84edaf
Compare
Rebased and added a new bound check for deserializing as the new |
I feel like we need more tests as new functionality has been added with this one. |
Hmm an issue with this PR is that it leaves |
Just pushed a commit adding binary serde to |
thanks, appreciate the help!! |
This PR improves the serde impls used to mainly de/serialize the
FieldElement
type. The de/serialization implementations now take into consideration whetherSerialize
/Deserialize
implementations should expect to de/serialize in human-readable form or not.This possibly(?) introduces a breaking change due to this PR #527.