feat: dynamic signer interactivity #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xJonathanLEI
force-pushed
the
dev/dynamic_signer_interactivity
branch
from
44ccda2 to
af107dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signer interactivity seems to also be non-binary. This PR enables signer implementations to make better interactivity reporting decision based on what's being signed.
A use case for this would be that calls to a specific contract on certain selectors might be deemed safe and would not require user confirmation. Apparently this needs to be enforced on the actual account contract, but having accurate interactivity on the client side helps the library make better decision on transaction estimation and simulation.
This is technically a breaking change on the existing
HEADbut since this whole interactivity feature hasn't been released yet so we're free to break anything.