feat: alternative (slow) pedersen hash impl optimized for size #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xJonathanLEI
force-pushed
the
dev/pedersen_no_lookup
branch
from
a26c796 to
ac3d632
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
pedersen_no_lookupfeature onstarknet-cryptothat changes the Pedersen hash implementation to an unoptimized one that's around 10x as slow. In exchange, the produced binary size would be smaller. This can be very useful in cases where binary size is very important (e.g. browser), whereas Pedersen hash is minimally used.This feature is not exposed through higher-level crates to avoid misuse, as enabling it imposes a heavy penalty on performance.