Yangtze Backports #5177
Merged
Yangtze Backports #5177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport of c882e81 The issue to be fixed in this commit is that when a host joins a pool in which the management network is on a VLAN network, the new untagged PIF of the joined host shows disconnected always. Normally, the VLAN untagged PIF should share PIF_metrics with the tagged PIF so that the PIF_metrics could be updated correctly. This sharing is ensured by 'Xapi_vlan.create'. While in pool.join, the untagged PIF is created by 'Xapi_pif.pool_introduce', in which the 'metrics' of the new untagged PIF doesn't share with the tagged PIF. This causes the 'carrier' of 'metrics' of the new untagged PIF be 'false' forever. And consequently the management network shows disconnected always. Can't switch to use 'Xapi_vlan.create' simply to fix this issue as the call can't set the "management" field of the untagged PIF correctly. The 'Xapi_pif.pool_introduce' can do this, but can't set the sharing of PIF_metrics correctly. What's more, from engineering's perspective, it is not worth to change these two API calls for this minor issue. So the fix is as simple as to reset the PIF_metrics of untagged PIF to the one used by tagged PIF when creating the VLAN object in pool.join. In this case, the only drawback is an unused PIF_metrics is created and then destroyed in pool.join. --------- Signed-off-by: Ming Lu <[email protected]> Signed-off-by: Christian Lindig <[email protected]>
Backport d23730d Using them makes it impossible to remove unrelated fields that were supposed to have been removed in 2012 Signed-off-by: Pau Ruiz Safont <[email protected]> Signed-off-by: Christian Lindig <[email protected]>
minglumlu
approved these changes
Sep 20, 2023
Backport of xapi-project#4908 RRD gains a new command (outside this repository) that we are using as part of bug tool collection. Signed-off-by: Christian Lindig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please remind me if any of this requires changes in spec files - this is easy to miss.