Backport XSI-1626, CA-392163 #5613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 30, 2024 10:21
Clear all (stale) scheduled assignments for: VM, PCI, VGPU objects on startup. We were missing the latter two. Signed-off-by: Christian Lindig <[email protected]>
As part of a start, resources are allocated for a VM in "scheduled_to.." fields. These need to be cleared if the start fails. It turned out that this was incomplete for PCI slots and those were leaking. This patch tries to be more systematical about it. Signed-off-by: Christian Lindig <[email protected]>
Signed-off-by: Christian Lindig <[email protected]>
psafont
reviewed
May 7, 2024
| (Db.VM.get_VGPUs ~__context ~self:vm) | ||
|
|
||
| let clear_reserved_netsriov_vfs_on ~__context ~vm = | ||
| let clear_vif_reservations ~__context ~vm = |
There was a problem hiding this comment.
While the code preserves the different behaviour for clearing vif reservations, it's strange that a separate function is needed at all for this instead of clearing all reservations whenever possible
There was a problem hiding this comment.
@robhoes had a comment about this. It is because the VIF mechanism is not following the scheduled/permanent assignment pattern.
robhoes
approved these changes
May 7, 2024
psafont
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid leaking (SR-IOV) PCI slots when a VM start fails; also clear out temporary reservations on xapi startup.