CA-390277: Fix cross-pool migration from CH8.2CU1 to XS8 when using xe #5717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwintorok
reviewed
Jun 20, 2024
psafont
force-pushed
the
yangtze-norecord-mig
branch
2 times, most recently
from
336a029 to
96882d1
Compare
robhoes
reviewed
Jun 20, 2024
robhoes
reviewed
Jun 20, 2024
psafont
force-pushed
the
yangtze-norecord-mig
branch
from
c7ad632 to
260b9f8
Compare
lindig
approved these changes
Jun 25, 2024
Host records have changed between CH8.2CU1 and XS8, this means that the records produced from an new host cannot be serialized by this code. Instead of making the remote host filter records, now the client tries to fetch the correct reference, and if it can't, fetches all references and fetches fields to find it. Records from Networks, PBDs and SRs are still used. Signed-off-by: Pau Ruiz Safont <[email protected]>
psafont
force-pushed
the
yangtze-norecord-mig
branch
from
6327abd to
8894e1b
Compare
|
I've reworked the approach to be more minimalistic in change. Now records for Networks, PBDs and SRs are still used, but this allows for fewer roundtrips, and cross-pool migrations to XS8 hosts work. |
|
so this and #5773 are two different PRs, why is there two? |
|
On master, we're adding a new call. This calls needs to be available on the remote server. This means that if we add this call here for Yangtze, cross-pool migration will only be compatible with new enough hosts. We want the migration to be compatible with as many versions of xapi as possible |
robhoes
approved these changes
Jul 4, 2024
lindig
approved these changes
Jul 4, 2024
|
Converting to draft to avoid premature merging, we need to run some automated tests on this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Host records have changed between CH8.2CU1 and XS8, this means that the
records produced from an new host cannot be serialized by this code.
Instead of making the remote host filter records, now the client tries
to fetch the correct reference, and if it can't, fetches all references
and fetches fields to find it.
Records from Networks, PBDs and SRs are still used.
I've manually verified that the cross-pool migrations now work