CA-386552 XSI-1534 Failed to disable pool HA after missing HA statefile #5941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport 5a639b1 The issue arises because: * xapi_ha.ml, function disable_internal * When a static VDI is removed from an SR (manually by deleting it from an NFS server, for example) * As the SR is re-scanned, it is also removed from the xapi database * But the re-scan does not remove it from the list of static VDIs in /etc/xensource/static-vidis * when the function is called, it obtains the list of static VDIs (the UUIds) * and looks them up in the database - which fails * static VDIs references are further listed in Pool.ha_statefile and can be stale. This patch hardens the code path to avoid failure when the statefile VDI has been removed manually. Signed-off-by: Christian Lindig <[email protected]>
robhoes
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 5a639b1
The issue arises because:
This patch hardens the code path to avoid failure when the statefile VDI has been removed manually.