CP-49140: prepare for database optimizations #6181
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently all of these are strings, but it may change: * table * db_ref * field_name * field * uuid This enables changing the `field` type from `string` and avoiding costly serialization/deserialization when not needed. No functional change. Signed-off-by: Edwin Török <[email protected]>
sexp_of is used when saving the schema, but of_sexp is unused. This enables a future commit to store the deserialized value as a pair value, and deserialization (unmarshaling) requires knowing the schema, whereas serialization (marshaling) does not. Thus we couldn't implement a generic `t_of_sexp` function, but with this change we won't have to. No functional change.
|
I'm tempted to suggest that this PR should be opened against master, it seems quite straightforward |
contificate
reviewed
Dec 13, 2024
Comment on lines
+88
to
90
| val read_field : Db_ref.t -> table -> db_ref -> field_name -> field | ||
| (** [read_field context tbl ref fld] returns the value of field [fld] | ||
| in row [ref] in table [tbl] *) |
There was a problem hiding this comment.
Need to be careful here, the doc comment is actually incorrect.
The correct order is:
val read_field : Db_ref.t -> table -> field_name -> db_ref -> fieldSee a corresponding DB action:
and get_enabled ~__context ~self =
let self = DM_to_String.ref_Observer self in
let __t = Context.database_of __context in
let module DB = (val (Xapi_database.Db_cache.get __t) : Xapi_database.Db_interface.DB_ACCESS) in
String_to_DM.bool (DB.read_field __t "Observer" "enabled" self)
lindig
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.