Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CP-49147: Reduce size of the pool record (uefi_certificates) #6182

Draft
wants to merge 1 commit into
base: feature/perf
Choose a base branch
from
Draft

CP-49147: Reduce size of the pool record (uefi_certificates) #6182

wants to merge 1 commit into from

Conversation

edwintorok
Copy link
Contributor

This field is very big and part of every pool.get_all_records() call (done by SM), which is currently >64KiB in size.

TODO: the Changed field needs to match the (future!) tag that this will receive. Hence draft.

@edwintorok
CP-49147: Reduce size of the pool record (uefi_certificates)
1e6f918 
This field is very big and part of every pool.get_all_records() call
(done by SM), which is currently >64KiB in size.

TODO: the Changed field needs to match the (future!) tag that this will receive.

Signed-off-by: Edwin Török <[email protected]>
lindig
lindig approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@lindig lindig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea is that very few clients will need the certificate and can use a new API call to obtain it. The existing field is replaced by a digest.

This seems fine with me as long as we control the relevant clients.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lindig lindig lindig approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edwintorok @lindig