Updates to Portable SR functionality #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifies functionality to understand the use of legacy format VDIs: - Adds an option to search for a legacy format VDI if a new one is not found - Handles the case where multiple legacy VDIs are identified - Passes the appropriate option to `xe-restore-metadata` when needed This is XSA-459 / CVE-2024-31144 Also update the subprocess calls to be compatible with python3 Signed-off-by: Alex Brett <[email protected]>
|
Associated xen-api PR xapi-project/xen-api#5841 |
andyhhp
approved these changes
Jul 16, 2024
GeraldEV
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies functionality to understand the use of legacy format VDIs:
xe-restore-metadatawhen neededThis is XSA-459 / CVE-2024-31144
Also update the subprocess calls to be compatible with python3