Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release 1.2.2 #99

Merged
merged 4 commits into from
Oct 31, 2023
Merged

chore: release 1.2.2 #99

merged 4 commits into from
Oct 31, 2023

Conversation

nicrie
Copy link
Contributor

@nicrie nicrie commented Oct 31, 2023

mainly:

  • perf(Dask): avoid running out of memory + faster
  • fix(EOF): reindexing transformed scores

For Dask setting compute=True in svd_compressed avoids that we run out of
memory + increases speed.
Resolved an issue where the coordinates of transformed scores were
incorrectly reindexed using the fitted data's reference frame. The indexing now correctly
utilizes the coordinates from the
tansformed data itself, ensuring accurate
alignment with the original dataset (closes #98).
@codecov-commenter
Copy link

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (e8f72d5) 94.29% compared to head (a8e458e) 94.25%.
Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
- Coverage   94.29%   94.25%   -0.05%     
==========================================
  Files          71       71              
  Lines        5539     5601      +62     
==========================================
+ Hits         5223     5279      +56     
- Misses        316      322       +6     
Files Coverage Δ
tests/models/test_eof.py 100.00% <100.00%> (ø)
xeofs/models/_base_model.py 93.05% <100.00%> (ø)
xeofs/models/eof.py 100.00% <ø> (ø)
xeofs/preprocessing/concatenator.py 91.07% <100.00%> (+0.33%) ⬆️
xeofs/preprocessing/dimension_renamer.py 94.11% <100.00%> (+0.36%) ⬆️
xeofs/preprocessing/list_processor.py 100.00% <100.00%> (ø)
xeofs/preprocessing/multi_index_converter.py 100.00% <100.00%> (ø)
xeofs/preprocessing/preprocessor.py 99.11% <100.00%> (+0.07%) ⬆️
xeofs/preprocessing/scaler.py 100.00% <100.00%> (ø)
xeofs/validation/bootstrapper.py 98.64% <100.00%> (ø)
... and 5 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicrie nicrie merged commit 17cb471 into main Oct 31, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants