fix(boolean): generate type boolean instead of `boolean | undefined…

…` for boolean fields Refs: dohomi#73
xaverfleer · Sep 18, 2024 · d675acd · d675acd
1 parent 0558910
commit d675acd
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/index.test.ts b/src/index.test.ts
@@ -43,13 +43,11 @@ describe("storyblokToTypescript", () => {
         const types = await storyblokToTypescript({
             componentsJson: makeSBComponent({
                 myField: { type: "boolean" },
-                myRequiredField: { type: "boolean", required: true },
             }),
         });
         const mainType = prepareString(types[2]);
         const expectation = makeExpectString(`
-            myField?: boolean;
-            myRequiredField: boolean;
+            myField: boolean;
         `);
 
         expect(mainType).toBe(expectation);
@@ -206,7 +204,7 @@ describe("storyblokToTypescript", () => {
             copyright?: string;
             fieldtype?: string;
             meta_data?: null|{[k:string]:any;};
-            is_external_url?:boolean;
+            is_external_url: boolean;
             [k: string]: any;
         }`);
 

diff --git a/src/index.ts b/src/index.ts
@@ -69,7 +69,10 @@ export default async function storyblokToTypescript({
             }
             const requiredFields = ['_uid', 'component']
             Object.keys(values.schema).forEach(key => {
-                if (values.schema[key].required) {
+                if (
+                    values.schema[key].required ||
+                    values.schema[key].type === "boolean"
+                ) {
                     requiredFields.push(key)
                 }
             })