Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Session] Set Atmos profile instead of JOC codec string #1745

Open
wants to merge 1 commit into
base: Piers
Choose a base branch
from

Conversation

CastagnaIT
Copy link
Collaborator

Description

Since has been merged ffmpeg 7.1 in to kodi core
xbmc/xbmc#24972
the string "eac3-joc" is no longer recognized as a workaround to display the atmos profile in the GUI
but in its place the atmos codec profile is now working so lets use it

no changes are required to codec handlers/readers since i had already prepared them for this change

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • I have read the Contributing document
  • My code follows the Code Guidelines of this project
  • My change requires a change to the Wiki documentation
  • I have updated the documentation accordingly

Since has been merged ffmpeg 7.1 in to kodi core
the string "eac3-joc" is no longer recognized as a workaround to display the atmos profile in the GUI
but in its place the atmos codec profile is now working
@CastagnaIT CastagnaIT added Type: Cleanup non-breaking change which removes non-working or unmaintained functionality v22 Piers labels Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Cleanup non-breaking change which removes non-working or unmaintained functionality v22 Piers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant