Skip to content

Commit

Permalink
Import fix for CVE-2018-1113
Browse files Browse the repository at this point in the history
Imported patch from redhat setup-2.8.71-10
From NIST:
 /sbin/nologin and /usr/sbin/nologin to /etc/shells.
 This violates security assumptions made by pam_shells and some daemons which allow access based on a user's shell being listed in /etc/shells.
 Under some circumstances, users which had their shell changed to /sbin/nologin could still access the system.

Signed-off-by: Lucas RAVAGNIER <[email protected]>
  • Loading branch information
Lucas RAVAGNIER committed Dec 4, 2024
1 parent bdb6284 commit 94e25f4
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 1 deletion.
10 changes: 10 additions & 0 deletions SOURCES/setup-2.8.71-CVE-2018-1113.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
diff -urNp setup-2.8.71-orig/shells setup-2.8.71/shells
--- setup-2.8.71-orig/shells 2013-06-07 16:31:32.000000000 +0200
+++ setup-2.8.71/shells 2018-06-21 13:09:40.352389479 +0200
@@ -1,6 +1,4 @@
/bin/sh
/bin/bash
-/sbin/nologin
/usr/bin/sh
/usr/bin/bash
-/usr/sbin/nologin
6 changes: 5 additions & 1 deletion SPECS/setup.spec
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
Summary: A set of system configuration and setup files
Name: setup
Version: 2.8.71
Release: 9.1%{?dist}
Release: 9.2%{?dist}
License: Public Domain
Group: System Environment/Base
URL: https://pagure.io/setup/
Expand All @@ -19,6 +19,7 @@ Source0: setup-%{xs_version}.tar.gz

# XCP-ng patches
Patch1000: setup-2.8.74.xs-delete-telemetry-user-and-group.XCP-ng.patch
Patch1001: setup-2.8.71-CVE-2018-1113.patch

BuildArch: noarch
BuildRequires: bash perl
Expand Down Expand Up @@ -203,6 +204,9 @@ end
%ghost %verify(not md5 size mtime) %config(noreplace,missingok) /etc/fstab
%changelog
* Wed Nov 20 2024 Lucas Ravagnier <[email protected]> - 2.8.71-9.2
- Import from 2.8.71-10 fix for CVE-2018-1113
* Tue Jun 04 2024 Samuel Verschelde <[email protected]> - 2.8.71-9.1
- Rebase on XenServer's 2.8.74-1, but keep versioning consistent with CentOS 7
- Restore upstream CentOS changelog, that had been deleted by XenServer
Expand Down

0 comments on commit 94e25f4

Please sign in to comment.