Support detaching xdp_link-based attachments fix #361 #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @tohojo |
msherif1234
force-pushed
the
fix_xdp_loader
branch
3 times, most recently
from
e1d2153 to
5a17836
Compare
tohojo
requested changes
Sep 21, 2023
There was a problem hiding this comment.
The basic functionality is basically there, nice job! Just a whole bunch of nits :)
Also, it would be good to add a selftest for this; could you please write add a small test utility in libxdp/tests that does something like:
link = bpf_link_attach(ifindex);
mp = xdp_multiprog__get_from_ifindex(ifindex);
xdp_multiprog__detach(mp);
bpf_link_close(link);You can look at some of the other examples in the tests/ directory for how to execute the tests from the test script :)
msherif1234
force-pushed
the
fix_xdp_loader
branch
from
5a17836 to
e3a1628
Compare
tohojo
requested changes
Sep 21, 2023
msherif1234
force-pushed
the
fix_xdp_loader
branch
6 times, most recently
from
033563e to
e3b6a88
Compare
make run
Executing tests in separate net- and mount namespaces
Running tests from ./test-libxdp.sh
[test_link_so] PASS
[test_link_a] PASS
[test_old_dispatcher] PASS
[test_xdp_frags] PASS
[test_xsk_prog_refcnt_bpffs] PASS
[test_xsk_prog_refcnt_legacy] PASS
[test_xsk_non_privileged] SKIPPED
[test_link_dispatch] PASS |
msherif1234
force-pushed
the
fix_xdp_loader
branch
from
e3b6a88 to
10bf826
Compare
tohojo
requested changes
Sep 21, 2023
| exit(EXIT_FAILURE); | ||
| } | ||
|
|
||
| static int check_link_detach(int ifindex) { |
There was a problem hiding this comment.
The indentation is off in this and the main() function below. We use a single tab character per indentation level everywhere.
msherif1234
force-pushed
the
fix_xdp_loader
branch
from
10bf826 to
971fe49
Compare
msherif1234
force-pushed
the
fix_xdp_loader
branch
4 times, most recently
from
d183e41 to
651960d
Compare
When explicitly detaching from an interface we should also handle bpf_link-based attachments (by force-detaching the link). Fixes xdp-project#361. Signed-off-by: Mohamed Mahmoud <[email protected]>
tohojo
approved these changes
Sep 21, 2023
Signed-off-by: Mohamed Mahmoud <[email protected]> [ fixup whitespace, rename test from link_dispatch to link_detach ] Signed-off-by: Toke Høiland-Jørgensen <[email protected]>
tohojo
force-pushed
the
fix_xdp_loader
branch
from
651960d to
aace046
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supporting force detach for link based attachments using
xdp-loader unload -a <intf>fixes #361