libxdp: Use opts to create XDP socket #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tohojo
force-pushed
the
feat/sock-opts
branch
from
3604acb to
bf7a318
Compare
magnus-karlsson
requested changes
Dec 9, 2024
headers/xdp/xsk.h
Outdated
| * The following fields should not be NULL at the same time: | ||
| * | ||
| * @rx, @tx | ||
| * At least one traffic direction should be assigned for an XSk. |
headers/xdp/xsk.h
Outdated
| * | ||
| * @fill, @comp, @rx_size, @tx_size, @libbpf_flags, @libxdp_flags, | ||
| * @xdp_flags, @bind_flags | ||
| * If a socket with exclusive ownership of a umem are going to be |
headers/xdp/xsk.h
Outdated
| * If the remaining fields are unset, they will be set to | ||
| * default value (see `xsk_set_xdp_socket_config()`). | ||
| * | ||
| * Except for the fields mentioned above, none field can be set. |
There was a problem hiding this comment.
"none field"? What does that mean?
headers/xdp/xsk.h
Outdated
| __u32 rx_size; | ||
| __u32 tx_size; | ||
| union { | ||
| __u32 libbpf_flags; |
There was a problem hiding this comment.
For this new interface, let us delete libbpf_flags and be done with the union. libbpf_flags was there just for compatibility with libbpf version prior to 1.0. For this new interface, we can skip this.
lib/libxdp/xsk.c
Outdated
|
|
||
| if (usr_cfg->libbpf_flags & ~XSK_LIBBPF_FLAGS__INHIBIT_PROG_LOAD) | ||
| libbpf_flags = OPTS_GET(opts, libbpf_flags, 0); | ||
| if (libbpf_flags & ~XSK_LIBBPF_FLAGS__INHIBIT_PROG_LOAD) |
There was a problem hiding this comment.
Please use LIBXDP instead of LIBBPF in this whole function. Again, the LIBBPF stuff in the interface is only there for some old libbpf compatibility. The local variable can be libxdp_flags too since we are in libxdp :-).
Introduce a new API xsk_socket__create_opts() to create XDP socket using opts struct. Note that if one of fill and comp is unset, the semantic of the new API is the same as xsk_socket__create(), otherwise the same as xsk_socket__create_shared(). Signed-off-by: Muyang Tian <[email protected]>
tacslon
force-pushed
the
feat/sock-opts
branch
from
bf7a318 to
449ed15
Compare
|
Updated changes LGTM - @magnus-karlsson WDYT? |
|
The test is failing, can be re-run @magnus-karlsson @tohojo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new API xsk_socket__create_opts() to create XDP socket using opts struct. Note that if one of fill and comp is unset, the semantic of the new API is the same as xsk_socket__create(), otherwise the same as xsk_socket__create_shared().