Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update timezones #50

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ukrbugreporter
Copy link

@ukrbugreporter ukrbugreporter commented Jul 11, 2023

Change timezone name to a more relevant one.
Source: https://en.wikipedia.org/wiki/List_of_tz_database_time_zones

Copy link
Collaborator

@bernhardkaindl bernhardkaindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While it would be politically preferable to use the Ukrainian word for the city for the timezone, I think it has to use what the Dom0 system understands, and so far I can't see Europe/Kyiv in the tzdata file of our current Dom0 rootfs:

grep -r Europe/K /usr/share/
/usr/share/zoneinfo/tzdata.zi:Z Europe/Kiev

Therefore, AFAIK, until we have more info we've to update to tzdata which understands Kyiv before we can merge this, unfortunately.

As far as I understand, this PR has to be blocked until a tzdata with it is available for XenServer/XCP for/in installations.

@GeraldEV
Copy link
Collaborator

We will shortly be updating the host-installer to Python 3, this PR looks like it will remain open for some time and will need updating to be Python 3 compatible (if not already) once the upgrade changes have been made

@freddy77
Copy link
Collaborator

freddy77 commented Dec 8, 2023

I think the issue here is system compatibility. We still use CentOS 7 which has no "Kyiv". Unless we make sure we have it (for instance adding a symbolic link) this change will break on CentOS 7.

@MarkSymsCtx
Copy link
Contributor

I think the issue here is system compatibility. We still use CentOS 7 which has no "Kyiv". Unless we make sure we have it (for instance adding a symbolic link) this change will break on CentOS 7.

We should probably update tzdata anyway for general system sanity. It typically gets updated fairly regularly on standard Linux distributions and whilst we were originally derived fro CentOS 7 we have long ago diverged into our own distribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants