Feature/hatching #1664
Draft
Feature/hatching #1664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijlal99
force-pushed
the
feature/hatching
branch
from
5c4e73a
to
91054bc
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| <meta name="viewport" content="width=device-width, initial-scale=1"> | ||
| <title>xeokit Example</title> | ||
| <link href="../css/pageStyle.css" rel="stylesheet" /> | ||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/5.13.0/js/all.min.js"></script> |
Check warning
Code scanning / CodeQL
Inclusion of functionality from an untrusted source Medium
ijlal99
force-pushed
the
feature/hatching
branch
from
91054bc
to
56dd443
Compare
ijlal99
force-pushed
the
feature/hatching
branch
3 times, most recently
from
1e838bd
to
806f495
Compare
| <meta name="viewport" content="width=device-width, initial-scale=1"> | ||
| <title>xeokit Example</title> | ||
| <link href="../css/pageStyle.css" rel="stylesheet"/> | ||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/5.13.0/js/all.min.js"></script> |
Check warning
Code scanning / CodeQL
Inclusion of functionality from an untrusted source Medium
ijlal99
force-pushed
the
feature/hatching
branch
from
806f495
to
ba604a5
Compare
ijlal99
force-pushed
the
feature/hatching
branch
from
ba604a5
to
ad8e78d
Compare
|
@MichalDybizbanskiCreoox please have a look at the PR when you some time now. I believe I have implemented everything apart from calculating intersections with a plane instead of a box. @xeolabs do you think we can beta release this feature or maybe I should first implement calculation of the intersecting box based on the bounding box of the scene? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @MichalDybizbanskiCreoox!
I have implemented somewhat the basics of what we discussed for the hatching branch.
Right now, I am using materials that are already provided by xeokit and I'd suggest that we should keep it that way instead of developing hatching patterns. I am struggling to create different type of materials for each object in the scene model, the baseColor does not seem to be effecting the materials. However, I have confirmed that the sectionCapsPlugin is correctly reading those materials and adding those to section caps.
I would like to suggest that we create a new material type for solids or basic colors.
@xeolabs maybe you can guide me to correctly implement different materials for each object, I am sure I am doing something wrong here.