[FIX] Regression for name of root object of TreeViewPlugin (XCD-174) #1700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
there is some form of regression described in XCD-174 that happened somewhere in between 2/10/2024 and 15/10/2024 and results in having "na" as the name of the root of the tree. You can see it in any example file with tree, like e.g. this one: https://xeokit.github.io/xeokit-sdk/examples/navigation/#TreeViewPlugin_Containment_Federated. What is strange about it is the fact that there are no obvious changes in the TreeViewPlugin in this period that I find suspicious. What could it be, change of the MetaModel itself?
Change in this PR seems to fix this issue, BUT it might be I overlooked something, and change should appear somewhere else. So please give it a try and check if I got it right.