Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SECURITY] Fix Zip Slip Vulnerability #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[SECURITY] Fix Zip Slip Vulnerability #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions jmccc/src/main/java/org/to2mbn/jmccc/launch/LauncherImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,10 @@ private void decompressZipWithExcludes(File zip, File outputDir, Set<String> exc
}

File outFile = new File(outputDir, entry.getName());

if (!outFile.toPath().normalize().startsWith(outputDir.toPath().normalize())) {
throw new IOException("Bad zip entry");
}
boolean match; // true if two files are the same
if (outFile.isFile() && outFile.length() == entry.getSize()) {
// same length, check the content
Expand Down