Allow spaces in NameHider

[L1shed]

Forgot to implement it on the first pr

Summary by CodeRabbit

• Bug Fixes
  • Improved command processing to handle arguments more accurately, enhancing the functionality and reliability of commands in the app.

[coderabbitai]

Walkthrough

The recent update in the Commands class focuses on refining the rCMD method. Specifically, the handling of command arguments has been altered, where the method now concatenates arguments starting from index 2, along with specific replacements. This change improves the way NameHider.n is constructed, enhancing the overall functionality.

Changes

File Path	Change Summary
src/main/java/keystrokesmod/utility/Commands.java	Modified the rCMD method to concatenate command arguments starting from index 2 with replacements for improved NameHider.n construction.

Poem

🐇
In the land of code where commands reside,
A change in method, no need to hide.
Arguments now join with grace,
Enhancing the NameHider's space.
A tweak, a twist, and now it's done,
Our code's new journey has just begun.
🎉

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

Outside diff range, codebase verification and nitpick comments (1)

src/main/java/keystrokesmod/utility/Commands.java (1)

93-93: Ensure correct replacement of characters.

The replacement of & with § is correct, but consider documenting why this replacement is needed for better code maintainability.

// Replace '&' with '§' to support color codes.
NameHider.n = args.get(1).replace("&", "§");

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 7cf84aa and 2caf8c3.

Files selected for processing (1)

• src/main/java/keystrokesmod/utility/Commands.java (1 hunks)

[coderabbitai]

Optimize string concatenation.

Using StringBuilder for concatenation within a loop improves performance and readability.

StringBuilder nameBuilder = new StringBuilder(NameHider.n);
for (int i = 2; i < args.size(); i++) {
    nameBuilder.append(" ").append(args.get(i).replace("&", "§"));
}
NameHider.n = nameBuilder.toString();

[xia-mc]

good