Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7.0 related small lib updates #193

Merged
merged 6 commits into from
Jun 28, 2024
Merged

7.0 related small lib updates #193

merged 6 commits into from
Jun 28, 2024

Conversation

ClayLivince
Copy link
Contributor

maybe there is no one else using sc lib but just ... create pull request here? incase there are really someone other using sc lib.

7.0 patch related fillings and add a small feature to allow lib always return high res icons.

And, Lgb and Sgb files changed a lot . Access to 'bg/ffxiv/sea_s1/twn/s1t2/level/planevent.lgb' file failed and tried to read it manually but all messy. maybe discuss it later.

@Supamiu
Copy link
Contributor

Supamiu commented Jun 28, 2024

Most of this looks good to me but the icon stuff, we already have uiHD command to extract HD stuff: https://github.com/xivapi/SaintCoinach/blob/master/SaintCoinach.Cmd/Commands/HDUiCommand.cs

@ClayLivince
Copy link
Contributor Author

ClayLivince commented Jun 28, 2024

yeah, uiHD is for SaintCoinach.Cmd, My changes here is a universal switch for sc lib calling methods for some XIV row .NET objects like Saint.Item.Icon etc.

@Supamiu Supamiu merged commit a2950f8 into xivapi:master Jun 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants