Allow copying paths out of the resource logger.

xivdev · Sep 9, 2024 · 0c6d777 · 0c6d777
1 parent bd59591
commit 0c6d777
Showing 1 changed file with 28 additions and 22 deletions.
diff --git a/Penumbra/UI/ResourceWatcher/ResourceWatcherTable.cs b/Penumbra/UI/ResourceWatcher/ResourceWatcherTable.cs
@@ -4,6 +4,7 @@
 using OtterGui.Classes;
 using OtterGui.Raii;
 using OtterGui.Table;
+using OtterGui.Text;
 using Penumbra.Enums;
 using Penumbra.Interop.Structs;
 using Penumbra.String;
@@ -52,36 +53,41 @@ public override void DrawColumn(Record item, int _)
 
     private static unsafe void DrawByteString(CiByteString path, float length)
     {
-        Vector2 vec;
-        ImGuiNative.igCalcTextSize(&vec, path.Path, path.Path + path.Length, 0, 0);
-        if (vec.X <= length)
+        if (path.IsEmpty)
+            return;
+
+        var size    = ImUtf8.CalcTextSize(path.Span);
+        var clicked = false;
+        if (size.X <= length)
         {
-            ImGuiNative.igTextUnformatted(path.Path, path.Path + path.Length);
+            clicked = ImUtf8.Selectable(path.Span);
         }
         else
         {
-            var        fileName = path.LastIndexOf((byte)'/');
-            CiByteString shortPath;
-            if (fileName != -1)
-            {
-                using var style = ImRaii.PushStyle(ImGuiStyleVar.ItemSpacing, new Vector2(2 * UiHelpers.Scale));
-                using var font  = ImRaii.PushFont(UiBuilder.IconFont);
-                ImGui.TextUnformatted(FontAwesomeIcon.EllipsisH.ToIconString());
-                ImGui.SameLine();
-                shortPath = path.Substring(fileName, path.Length - fileName);
-            }
-            else
+            var fileName = path.LastIndexOf((byte)'/');
+            using (ImRaii.Group())
             {
-                shortPath = path;
+                CiByteString shortPath;
+                if (fileName != -1)
+                {
+                    using var font = ImRaii.PushFont(UiBuilder.IconFont);
+                    clicked = ImUtf8.Selectable(FontAwesomeIcon.EllipsisH.ToIconString());
+                    ImUtf8.SameLineInner();
+                    shortPath = path.Substring(fileName, path.Length - fileName);
+                }
+                else
+                {
+                    shortPath = path;
+                }
+
+                clicked |= ImUtf8.Selectable(shortPath.Span, false, ImGuiSelectableFlags.AllowItemOverlap);
             }
 
-            ImGuiNative.igTextUnformatted(shortPath.Path, shortPath.Path + shortPath.Length);
-            if (ImGui.IsItemClicked())
-                ImGuiNative.igSetClipboardText(path.Path);
-
-            if (ImGui.IsItemHovered())
-                ImGuiNative.igSetTooltip(path.Path);
+            ImUtf8.HoverTooltip(path.Span);
         }
+
+        if (clicked)
+            ImUtf8.SetClipboardText(path.Span);
     }
 
     private sealed class RecordTypeColumn : ColumnFlags<RecordType, Record>