More refactoring #92
Open
More refactoring #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* removed one import prematurely
I think you need to rebase with master to view it accordingly. |
|
@adamnemecek is this ready to review? |
mats-claassen
requested changes
Feb 23, 2018
| @@ -20,7 +20,7 @@ public extension TFOptimizer { | |||
| /// This information can later be used by the 'activationNeuron' function | |||
| func addNeuronIfThere(node: TFNode) { | |||
| let outgoing = node.outgoingNodes() | |||
| if outgoing.count == 1, let next = (outgoing.first as? TFNode), | |||
| if let next = (outgoing.first as? TFNode), | |||
There was a problem hiding this comment.
I think we don't want to remove this check. There could be more than one outgoingNodes
| assert(inputNodes.count == startNodes.count, "Number of network inputs(\(inputNodes.count)) and input sizes(\(startNodes.count)) are not equal") | ||
| if inputNodes.count == 1 { | ||
| inputNodes[0].addIncomingEdge(from: startNodes[0]) | ||
| if let first = inputNodes.first { |
There was a problem hiding this comment.
This is not correct. If there are many inputNodes we want to go into the else
|
Hey, we have run the Swiftlint autocorrect and have added it to the CI check. Can you rebase your changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Im not sure why it shows all the commits, the real changes start with "trimmed whitespace" (including that one)