-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Queryable Content Types in Rust #74
base: main
Are you sure you want to change the base?
Conversation
|
||
#### 2. An older XMTP SDK version sends messages with old JSON content types to users on newer SDK versions | ||
|
||
One option is for integrator targeted SDKs to retain code for decoding older JSON content types. A second option is to update integrator targeted SDKs to only support the latest protobuf based content types that will work in new content type based message functions, and to only use fallback text for messages that are not compatible with the latest content types. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree that backwards compatibility isn't the top priority. The only thing that makes me lean towards the first option is how straightforward it should be.
Will make integrators lives easier if they can trust that any reaction they see will be decoded properly. I worry that if we don't integrators will see the fallback from older messages and try to parse it or manually decode the content.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I worry that if we don't integrators will see the fallback from older messages and try to parse it or manually decode the content.
Good point, and I agree it shouldnt be too difficult. Updated here f403869. (also simplified the backwards compatability section since it can be summarized as two cases instead of four)
Adding initial draft
To do: