-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retry PoolNeedsConnection Errors #1010
Changes from all commits
45adbfe
81ed193
0fe99ae
a09431d
514225e
db0ca10
04be5f2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -68,6 +68,7 @@ impl RetryableError for StorageError { | |
Self::Pool(_) => true, | ||
Self::Lock(_) => true, | ||
Self::SqlCipherNotLoaded => true, | ||
Self::PoolNeedsConnection => true, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This means the error will retry 5 times before erroring. That might be okay? I also took a pass at just doing it in the code and retrying 3 times here 45adbfe open to others thoughts on how we should handle this. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This definitely feels like it should be retryable. Thanks for fixing |
||
_ => false, | ||
} | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should cover the case converse is hitting when the database is trying to reconnect after getting a signature from a different app for revoking installations.