Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add libxmtp version to requests #1011

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Add libxmtp version to requests #1011

merged 1 commit into from
Aug 29, 2024

Conversation

neekolas
Copy link
Contributor

@neekolas neekolas commented Aug 29, 2024 •
edited
Loading

tl;dr

  • Starts setting the x-app-version and x-libxmtp-version headers in all requests

Issues

More info

  • The libxmtp_version gets taken from the version field in xmtp_mls/Cargo.toml. This gets set from the [workspace.package] version in the root Cargo.toml which is inherited by everything else

@neekolas Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @neekolas and the rest of your teammates on Graphite Graphite

@neekolas neekolas force-pushed the 08-28-add_libxmtp_version_to_requests branch 2 times, most recently from f2459ec to 63cb554 Compare August 29, 2024 07:21
@neekolas neekolas requested a review from nplasterer August 29, 2024 14:02
@neekolas neekolas requested a review from insipx August 29, 2024 14:04
@neekolas neekolas force-pushed the 08-28-add_libxmtp_version_to_requests branch from 63cb554 to db8127c Compare August 29, 2024 14:13
@neekolas neekolas marked this pull request as ready for review August 29, 2024 14:13
@neekolas neekolas requested a review from a team as a code owner August 29, 2024 14:13
insipx
insipx reviewed Aug 29, 2024
View reviewed changes
xmtp_api_http/src/lib.rs Show resolved Hide resolved
mls_validation_service/Cargo.toml Outdated Show resolved Hide resolved
@neekolas
Copy link
Contributor Author

@insipx

what's wrong with version.workspace?

Think you got there just before I pushed up a change to do that everywhere I could

@neekolas neekolas force-pushed the 08-28-add_libxmtp_version_to_requests branch 3 times, most recently from beb1dcd to b8dd616 Compare August 29, 2024 17:21
@neekolas neekolas force-pushed the 08-28-add_libxmtp_version_to_requests branch from b8dd616 to 5402910 Compare August 29, 2024 17:27
@neekolas neekolas enabled auto-merge (squash) August 29, 2024 17:28
@neekolas neekolas requested a review from insipx August 29, 2024 17:44
@neekolas neekolas merged commit 03471ef into main Aug 29, 2024
10 checks passed
@neekolas neekolas deleted the 08-28-add_libxmtp_version_to_requests branch August 29, 2024 17:48
@insipx insipx mentioned this pull request Aug 29, 2024
Open
This was referenced Aug 30, 2024
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@insipx insipx insipx approved these changes

@nplasterer nplasterer Awaiting requested review from nplasterer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neekolas @insipx