Teach example/CLI how to talk to V4/Replication Node #1214
Conversation
mkysel
force-pushed
the
mkysel/cli-register
branch
from
ebde379 to
5ffd6c7
Compare
mkysel
changed the title
| query: Some(EnvelopesQuery { | ||
| topics: vec![build_group_message_topic(req.group_id.as_slice())], | ||
| originator_node_ids: vec![], | ||
| last_seen: None, |
There was a problem hiding this comment.
As a note - the PagingInfo of the QueryGroupMessagesRequest has an id_cursor that we could potentially convert into vector clock format here as a short-term hack. Unsure if we get subtle bugs without this, as the client expects to query from where it left off in the queue. In the long-term we need to do a bigger refactor to properly support vector clocks though, just making a note in case you run into bugs in the meantime
| originator_node_ids: vec![], | ||
| last_seen: None, | ||
| }), | ||
| limit: 100, |
There was a problem hiding this comment.
There is a limit on the PagingInfo we should honor here
|
|
||
| GroupMessage { | ||
| version: Some(group_message::Version::V1(group_message::V1 { | ||
| id: unsigned_originator_envelope.originator_sequence_id, |
There was a problem hiding this comment.
Just making a note, eventually we'll need to refactor the client to store both the originator node id and sequence ID in order to set the vector clock properly, but this is great for now
| originator_node_ids: vec![], | ||
| last_seen: None, | ||
| }), | ||
| limit: 100, |
There was a problem hiding this comment.
To avoid bugs, I think we should take in the last_seen and limit from the caller of this method, and honor whatever semantics were previously used
| @@ -0,0 +1,138 @@ | |||
| use openmls::prelude::tls_codec::Error as TlsCodecError; | |||
There was a problem hiding this comment.
Is this error.rs file generated? Maybe I missed something, why do we need a new error type different from before?
There was a problem hiding this comment.
I just moved it to its own file as a drive-by refactor.
I added the InternalError and all of its subtypes to allow for error conversions.
This is the first (large) step in the right direction. By no means is the migration to decentralization complete.
This teaches the CLI to do basic operations via xtmpd such as:
One has to simply provide the
--testnetflag to the CLI and everything will work against the new API.The easiest way to spin up the new environment is to wait for #1281.
This refactors the Error class into its own file and adds an Internal error.
Also adds a new command to the CLI for debugging.