Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor of stream_all_messages, fix flaky stream tests #835

Merged
merged 35 commits into from
Jul 16, 2024
Merged
Show file tree
Hide file tree
Changes from 30 commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
70dc4ef
quick pass at stream_all_msg refactor
insipx Jun 11, 2024
f6e5b66
tests pass
insipx Jun 12, 2024
292fad6
try replacing StreamCloser with JoinHandle
insipx Jun 12, 2024
f0c91bd
use Notify
insipx Jun 26, 2024
d55304e
Merge branch 'main' of github.com:xmtp/libxmtp into insipx/async-call…
insipx Jun 26, 2024
a56a5cd
fix, not needed to wait on new groups
insipx Jun 26, 2024
8695b91
slowly fixing streaming tests
insipx Jun 26, 2024
a0e53fd
stream closer
insipx Jun 27, 2024
5fb9717
Merge branch 'main' of github.com:xmtp/libxmtp into insipx/async-call…
insipx Jun 27, 2024
3748bee
ignore errors resulting from cancellation of the task
insipx Jun 27, 2024
7115f51
simplify stream_all_messages even further
insipx Jun 27, 2024
4f323c4
progress. a custom sync solution similiar to notify might be good
insipx Jun 27, 2024
95f3a24
debug stream_all_messages
insipx Jul 1, 2024
a9e1a91
remove printlns
insipx Jul 1, 2024
281c364
notify only stores one permit
insipx Jul 1, 2024
9b96dc6
comment about missed messages
insipx Jul 1, 2024
a8c2aae
whitespace
insipx Jul 1, 2024
a641d2f
Merge branch 'main' of github.com:xmtp/libxmtp into insipx/async-call…
insipx Jul 1, 2024
e669a0f
fix node bindings
insipx Jul 1, 2024
6e1a961
refactor to allow waiting for stream readiness
insipx Jul 1, 2024
5910e5c
annotate streams correctly
insipx Jul 1, 2024
36d1c34
fix mls tests
insipx Jul 1, 2024
866bd10
revert logging
insipx Jul 1, 2024
2bae690
use std::mem::replace to try and avoid lost messages
insipx Jul 1, 2024
f596e4b
fmt
insipx Jul 1, 2024
f619147
fmt
insipx Jul 1, 2024
a5799b0
fmt
insipx Jul 1, 2024
2fc66d1
Merge branch 'insipx/async-callback' of github.com:xmtp/libxmtp into …
insipx Jul 1, 2024
9c916ae
cleanup
insipx Jul 2, 2024
5069ca1
some tests still flaky
insipx Jul 9, 2024
2db52c3
Merge branch 'main' of github.com:xmtp/libxmtp into insipx/async-call…
insipx Jul 11, 2024
236e882
make tests easier to debug
insipx Jul 15, 2024
7df1306
default for deliveyr
insipx Jul 15, 2024
70419cf
lose all messages test is definitely flaky
insipx Jul 15, 2024
23150d5
Merge branch 'main' of github.com:xmtp/libxmtp into insipx/async-call…
insipx Jul 16, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

99 changes: 98 additions & 1 deletion bindings_ffi/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions bindings_ffi/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ xmtp_proto = { path = "../xmtp_proto", features = ["proto_full", "grpc"] }
xmtp_user_preferences = { path = "../xmtp_user_preferences" }
xmtp_v2 = { path = "../xmtp_v2" }

tracing-subscriber = { version = "0.3", features = ["env-filter"] }
# NOTE: A regression in openssl-sys exists where libatomic is dynamically linked
# for i686-linux-android targets. https://github.com/sfackler/rust-openssl/issues/2163
#
Expand All @@ -46,6 +47,7 @@ tempfile = "3.5.0"
tokio = { version = "1.28.1", features = ["full"] }
tokio-test = "0.4"
uniffi = { version = "0.27.2", features = ["bindgen-tests"] }
tracing-subscriber = "0.3"
uuid = { version = "1.9", features = ["v4", "fast-rng" ] }

# NOTE: The release profile reduces bundle size from 230M to 41M - may have performance impliciations
Expand Down
Loading