Adding pinned frame metadata field #888
Merged
+186
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameronvoell
force-pushed
the
cv/pinned-frame
branch
from
c87f744
to
931a4f5
Compare
1 task
alexrisch
approved these changes
Jul 2, 2024
nplasterer
approved these changes
Jul 2, 2024
bindings_ffi/src/mls.rs
Outdated
| @@ -647,6 +651,7 @@ impl FfiCreateGroupOptions { | |||
| name: self.group_name, | |||
| image_url_square: self.group_image_url_square, | |||
| description: self.group_description, | |||
| pinned_frame: self.pinned_frame, | |||
There was a problem hiding this comment.
Should this be pinned frame url to be more explicit it's a url?
There was a problem hiding this comment.
probably right I'll update that and fix these node bindings tests before merging 👌
There was a problem hiding this comment.
updated 656c2c6
cameronvoell
force-pushed
the
cv/pinned-frame
branch
from
a2b3a5b
to
f94898d
Compare
This was referenced Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new metadata field
GroupPinnedFrameUrl