Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload key package before publishing identity updates #962

Merged

Conversation

neekolas
Copy link
Contributor

@neekolas neekolas commented Aug 14, 2024

TL;DR

Implements parts of xmtp/xmtp-node-go#399

  • Uses UploadKeyPackage instead of RegisterInstallation so we can deprecate the register installation endpoint
  • Uploads key package before publishing the identity updates for new installations. This ensures that any installation seen in an identity update must have a matching key package.
  • No longer checks the lifetime of key packages when verifying

AI Assisted Summary

What changed?

  • Removed expiration checks and set expiration to 0 in MLS validation service
  • Updated the client registration process to register identity before applying signature request
  • Renamed register_installation to upload_key_package in API client calls
  • Removed lifetime validity checks from key package verification

Copy link
Contributor Author

neekolas commented Aug 14, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @neekolas and the rest of your teammates on Graphite Graphite

This was referenced Aug 14, 2024
@neekolas neekolas marked this pull request as ready for review August 14, 2024 23:01
@neekolas neekolas requested a review from a team as a code owner August 14, 2024 23:01
@@ -70,9 +70,6 @@ impl VerifiedKeyPackage {
),
);
}
if !kp.life_time().is_valid() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not so worried about removing these checks, since no key packages are more than a few months old. They all have 6 month expirations, so none will be expired until long after this code is widely deployed.

Copy link
Contributor Author

neekolas commented Aug 15, 2024

Merge activity

  • Aug 14, 5:32 PM PDT: @neekolas started a stack merge that includes this pull request via Graphite.
  • Aug 14, 5:33 PM PDT: @neekolas merged this pull request with Graphite.
  • Aug 27, 10:34 AM PDT: @neekolas started a stack merge that includes this pull request via Graphite.

@neekolas neekolas merged commit 26b1fe5 into main Aug 15, 2024
8 checks passed
@neekolas neekolas deleted the 08-13-upload_key_package_before_publishing_identity_updates branch August 15, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants