Write the context proposal #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make StorageId Public
The memory storage clear proposal function is working now. This required a small change to the storage API such that we know the ProposalRef type. There's also a test for the proposals in the storage crate now.
neekolas
approved these changes
May 16, 2024
|
Yep there is just one function that @cameronvoell added for group mutable metadata which hasn't been contributed back to openMLS main. (which was where the bug was) But now that it's working I think we can feel confident in contributing that back. |
|
Contributed the fix back here: openmls#1580 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix up context writing.