Merge V3 into main #101
Merged
Merge V3 into main #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: use vmac instead of voodoo codename
Co-authored-by: Richard Hua <[email protected]>
Update V3 proto types
Co-authored-by: Richard Hua <[email protected]>
Add v3 invites
Wallet address on association
…nature instead of header hash
Adds new message protos for Padlock messages
Add is_prekey_message field to sealed metadata
Signed ECIES Payloads
nplasterer
approved these changes
Oct 13, 2023
|
🎉 This PR is included in version 3.28.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The V3 branch hasn't been doing much for us, other than causing confusion. All V3 protos live in their own package and we don't have any plans of modifying existing protos for V3 work.
Given that, let's just target everything at
mainwith a clear understanding that anything in the v3 folder should be taken as provisional and that breaking changes are still possible/likely.Follow-ups
Modify
libxmtpto point tomainfor proto generation