Update proto messages #103
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nplasterer
approved these changes
Oct 13, 2023
| // SealedSender wrapper for arbitrary bytes | ||
| message SealedSender { | ||
| bytes ephemeral_public_key = 1; | ||
| bytes ephemeral_static_key = 2; |
There was a problem hiding this comment.
What is the ephemeral_static_key?
Comment on lines
+25
to
+31
| message Metadata { | ||
| string sender_user_address = 1; | ||
| string sender_installation_id = 2; | ||
| string recipient_user_address = 3; | ||
| string recipient_installation_id = 4; | ||
| bool is_prekey_message = 5; | ||
| } |
There was a problem hiding this comment.
Are we feeding this whole blob into AES as the equivalent of the senderIdentityPublic input in https://signal.org/blog/sealed-sender/, or as the equivalent of the sender_certificate?
| string convo_id = 3; | ||
| bytes content_bytes = 4; // EncodedContent | ||
| message MessagePayloadV1 { | ||
| EdDsaSignature header_signature = 1; // Signature of the header_bytes |
There was a problem hiding this comment.
Depending on the details of how we are implementing sealedsender, I'm wondering if we still need to sign this
|
Closing this to focus on MLS work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates the Protobuf message types in V3.
The goals of these changes are:
MessageBackupRequestandMessageBackupResponsemessages are always sent from another installation and don't fit into the typical conversation model. They don't need to be wrapped inEncodedContentNotes
I copied the
EncodedContentmessage format in to the V3 folder verbatim. This is mostly just so that V3 never has to reference V2 types, which allows us to import more narrowly and will make the eventual deprecation of V2 types easier.