Simplify batch queries #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @richardhuaaa and the rest of your teammates on |
neekolas
reviewed
Oct 9, 2024
neekolas
reviewed
Oct 9, 2024
Closed
neekolas
approved these changes
Oct 9, 2024
richardhuaaa
added a commit
to xmtp/xmtpd
that referenced
this pull request
Oct 11, 2024
These are the minimal accompanying code changes for xmtp/proto#218, which are a prerequisite for #126. - Flattens query requests into a simpler structure - Publishes and queries are now *batch* publishes and queries. For now, we operate against the *first* item in the batch - I added tasks to properly implement the batching and unit tests later, but don't treat it as high priority for now - Adds a common method to validate batch query requests (refactored out from the subscribe worker)
|
🎉 This PR is included in version 3.72.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
batchfrom all endpoint namesrepeatedfield cannot be placed inside aoneoffield, so I decided to remove theoneof filteras the alternative is multiple layers of nesting.This and the next PR are fairly disruptive changes, heads up @mkysel. I'll take care of the server-side code changes, let me know if you'd like me to fix up client changes.
xmtp/xmtpd#126