Add new Subscribe2 method #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neekolas
commented
Aug 22, 2023
| title: "MessageApi"; | ||
| version: "1.0"; | ||
| }; | ||
| info: { |
There was a problem hiding this comment.
Not sure why my formatter is different from what was used for this file. We should probably add some vscode config to standardize everyone
mkobetic
reviewed
Aug 22, 2023
mkobetic
reviewed
Aug 22, 2023
| } | ||
| ; | ||
| } | ||
| ; |
There was a problem hiding this comment.
Is this what the formatter is forcing? This looks terrible.
There was a problem hiding this comment.
Completely agree. I tried using a different formatter and that one fails the linter. So, I'm kinda stuck.
mkobetic
approved these changes
Aug 22, 2023
|
🎉 This PR is included in version 3.27.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Our current Subscribe API is limited by the fact that it was built for browser clients. You cannot update subscriptions. To add or remove topics from a subscription, you have to close the existing subscription and create a new one. This is because browsers do not support bidirectional GRPC streaming. With iOS, Android, and Rust native supporting full-fledged GRPC, this limitation doesn't apply.
This PR creates a new SubscribeV2 GRPC service that allows clients to update their subscriptions without disconnecting. These small disconnects are a pain point for apps who rely on streams to get new messages. When using
conversations.streamAllMessagesthese disconnects happen every time a new conversation is started, since the stream needs to include the new conversation topics.This change has the added benefit of decreasing load on our nodes, since we wouldn't have to tear down and recreate the subscriptions every time a topic is added.