Fixing background image issues for homepage hero section #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Deploying xmtp-org with
|
| Latest commit: |
84ffdc5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f63e9bfc.website-9re.pages.dev |
| Branch Preview URL: | https://fix-home-bg.website-9re.pages.dev |
jhaaaa
changed the title
rygine
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview: https://vercel.live/open-feedback/junk-range-possible-git-fix-home-bg-ephemerahq.vercel.app
Currently, the background image for the homepage hero section works in dark mode:
However, it is not displaying correctly in light mode:
It should look more like this, which is what this PR does:
For smaller screens, the width of the background image in dark mode scales and anchors to the top of the homepage hero section. However, the image does not span the height of the section, which looks odd:
It should look more like this, which is what this PR does: