Bump Rust Version #174
Merged
Bump Rust Version #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nplasterer
commented
Oct 11, 2023
| @@ -174,7 +174,7 @@ public struct RemoteAttachmentCodec: ContentCodec { | |||
| throw RemoteAttachmentError.invalidScheme("no scheme parameter") | |||
| } | |||
|
|
|||
| if (!schemeString.starts(with: "https")) { | |||
| if (!schemeString.hasPrefix(RemoteAttachment.Scheme.https.rawValue)) { | |||
There was a problem hiding this comment.
Changed this to hasPrefix since that seems to be more inline with how swift would do this.
nplasterer
commented
Oct 11, 2023
| @@ -26,7 +26,7 @@ let package = Package( | |||
| .package(url: "https://github.com/1024jp/GzipSwift", from: "5.2.0"), | |||
| .package(url: "https://github.com/bufbuild/connect-swift", from: "0.3.0"), | |||
| .package(url: "https://github.com/apple/swift-docc-plugin.git", from: "1.0.0"), | |||
| .package(url: "https://github.com/xmtp/xmtp-rust-swift", from: "0.3.1-beta0"), | |||
| .package(url: "https://github.com/xmtp/xmtp-rust-swift", from: "0.3.5-beta0"), | |||
There was a problem hiding this comment.
Bumping this for anyone using SPM as well.
nplasterer
changed the title
nakajima
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps to the latest Rust version which drops the timeouts lower so they aren't noticeable.
I was not able to reproduce
Remote attachments don’t work between the xmtp.chat and iOS XMTP.RemoteAttachmentError.invalidScheme("invalid scheme value. must be https://")But I modified some of the error messages to confirm that the latest version of swift is getting run.