Add sender HMAC to MessageV2 #218
Conversation
kele-leanes
force-pushed
the
np/ios-entitlement
branch
from
e97f3ba
to
e269e40
Compare
kele-leanes
force-pushed
the
np/ios-entitlement
branch
from
847c930
to
98f3fb4
Compare
kele-leanes
force-pushed
the
np/ios-entitlement
branch
from
98f3fb4
to
d99a1c8
Compare
* rename module from XMTP to XMTPiOS * more renaming * remove xmtp-rust-swift references * Use new V2 client from libxmtp * building clean * remove PublishResponse * Use actual dep instead of local * Update XMTP.podspec Co-authored-by: Naomi Plasterer <[email protected]> * implement streaming and pagination * Update XMTP.podspec Co-authored-by: Cameron Voell <[email protected]> * disable file_length linter --------- Co-authored-by: Naomi Plasterer <[email protected]> Co-authored-by: Cameron Voell <[email protected]>
* Access libxmtp-swift with static binaries * Update libxmtp ref * Updated reference to libxmtp-swift merge on main
* Add Key Material Function (#222) * add ket material field to ios * bump the podspec * Update podspec LibXMTP ref * Update libxmtp-swift refs * Update libxmtp-swift ref * Updated libxmtp-swift ref to tagged release * Update XMTP.podspec version --------- Co-authored-by: cameronvoell <[email protected]>
…into np/ios-entitlement
| @@ -9,6 +9,10 @@ import XCTest | |||
| @testable import XMTPiOS | |||
|
|
|||
| struct NumberCodec: ContentCodec { | |||
| func shouldPush(content: Double) throws -> Bool { | |||
There was a problem hiding this comment.
Would you mind adding a test in here that shows you can get the shouldPush method correctly from the decodedMessage kind of like we should have fallback tests. 🙏
There was a problem hiding this comment.
seems that Xmtp_MessageContents_EncodedContent does not have the shouldPush method available which is where the fallback is coming from. Should I get it from there or from a different place?
There was a problem hiding this comment.
That was my bad from looking at JS it's on the messagev2 so wrote a test for that scenario and pushed it up. 1967934
There was a problem hiding this comment.
Looks like you have two legit linter issues
/Users/runner/work/xmtp-ios/xmtp-ios/Sources/XMTPiOS/Messages/MessageV2.swift:105:91: error: Force Unwrapping Violation: Force unwrapping should be avoided
/Users/runner/work/xmtp-ios/xmtp-ios/Sources/XMTPiOS/ConversationV2.swift:249:50: error: Force Cast Violation: Force casts should be avoided (force_cast)
|
the crypto code seems OK, but i'll defer to someone with more knowledge. all the other pieces look to be in the right places. |
|
@kele-leanes do you mind bumping the pod spec so we can consume this in RN? |
Closes #216
Follows the pattern put in place here: xmtp/xmtp-js#519
This fixes the iOS entitlement issue for push notifications by adding additional information to the payload. See: xmtp/XIPs#35