Restore Automated CI Testing #267
Merged
+127
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zombieobject
commented
Feb 27, 2024
zombieobject
commented
Feb 27, 2024
| @@ -280,7 +290,7 @@ class ClientTests: XCTestCase { | |||
| let opts = ClientOptions(api: ClientOptions.Api(env: .local, isSecure: false), preEnableIdentityCallback: preEnableIdentityCallback ) | |||
| do { | |||
| _ = try await Client.create(account: fakeWallet, options: opts) | |||
| await XCTWaiter().fulfillment(of: [expectation], timeout: 5) | |||
| await XCTWaiter().fulfillment(of: [expectation], timeout: 30) | |||
There was a problem hiding this comment.
The XCTWaiter calls were timing out during GH workflow runs but not locally.
As a practice, I've been trained not to depend on Async tests like these to other services as the results can vary from test to test. I'll monitor these to see how they perform and either reduce the timeout or change the test paradigm altogether using mocks, spies, and doubles.
Just Build Phase for Now Fix Broken Test Restore Test Phase Debug Xcode Select Version Restore Remaining Workflow Update libxmtp-swift version to 0.4.2-beta4 Update xmtplib Docker scripts Update macOS Version Run against latest Xcode Colima Debug Fix broken test Increased Timeout for Waiters Cleanup Workflow and Compose Additional workflow cleanup Final Workflow Cleanup Update Workflow Requirement
zombieobject
force-pushed
the
fixes/restore-testing-workflow
branch
from
c467073
to
177f2fc
Compare
neekolas
approved these changes
Feb 27, 2024
alexrisch
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction 📟
This Pull Request is intended to restore automated test functionality for all future Pull Requests as well as approved changes to
main