feat: Consent Proof Payload #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 17, 2024 19:17
Updated invitiation protos Added handling for consent proof signature on conversation creation
…sation Added Test
nplasterer
reviewed
Apr 19, 2024
| } | ||
| return nil | ||
| case .group(_): | ||
| return nil |
There was a problem hiding this comment.
Is there a world where this would be valid for groups as well. 🤔 Like you subscribe to a group?
There was a problem hiding this comment.
Maybe, but not at the current moment, I will add it to the group tracking issue
added 3 commits
April 19, 2024 15:42
Added signature verification
Cleaned up types Added decoding/encoding for ConsentProofPayload and version
nplasterer
approved these changes
Apr 23, 2024
cameronvoell
added a commit
that referenced
this pull request
Apr 25, 2024
This reverts commit c4dc517.
cameronvoell
added a commit
that referenced
this pull request
Apr 25, 2024
This reverts commit c4dc517. Co-authored-by: cameronvoell <[email protected]>
alexrisch
added a commit
that referenced
this pull request
Apr 26, 2024
alexrisch
added a commit
that referenced
this pull request
Apr 26, 2024
alexrisch
added a commit
that referenced
this pull request
Apr 29, 2024
* Revert "Revert "feat: Consent Proof Payload (#317)" (#328)" This reverts commit 7fcd96d. * feat: Consent Proofs Fixed handling for empty consent proofs --------- Co-authored-by: Alex Risch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction 📟
Updated invitiation protos
Added handling for consent proof signature on conversation creation
Purpose ℹ️
XIP
Tracking issue: #309
Scope 🔭