Fix SQL App Group Crash #339
Merged
+64
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nplasterer
commented
May 23, 2024
| @@ -462,6 +462,21 @@ public final class Client { | |||
| let fm = FileManager.default | |||
| try fm.removeItem(atPath: dbPath) | |||
| } | |||
|
|
|||
| @available(*, deprecated, message: "This function is delicate and should be used with caution. App will error if database not properly reconnected. See: reconnectLocalDatabase()") | |||
There was a problem hiding this comment.
@insipx was able to mark this function as delicate to warn developers before using.
nplasterer
commented
May 23, 2024
| try client.releaseDbConnection() | ||
| } | ||
|
|
||
| public func reconnectLocalDatabase() async throws { |
There was a problem hiding this comment.
Should be any reason to mark this as delicate because if they try to reconnect a already connected database nothing bad should happen right?
cameronvoell
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should close #336
This adds two new functions that should be called on background and foreground of the app when using app groups with the local database to disconnect and reconnect the database to avoid crashing.