This repository has been archived by the owner on Oct 10, 2024. It is now read-only.
fix: normalize reaction encoding, support legacy form #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2f3617b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Sep 5, 2023
nplasterer
approved these changes
Sep 5, 2023
dmccartney
force-pushed
the
daniel-fix-reaction-form
branch
2 times, most recently
from
e07098f
to
ec31f82
Compare
rygine
reviewed
Sep 5, 2023
dmccartney
force-pushed
the
daniel-fix-reaction-form
branch
from
ec31f82
to
ae64489
Compare
dmccartney
force-pushed
the
daniel-fix-reaction-form
branch
from
ae64489
to
e71d72b
Compare
rygine
reviewed
Sep 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the JS portion of how reactions are encoded across codec implementations.
See xmtp/xmtp-react-native#93 (comment)