Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call onConnectionLost on all errors #291

Merged
merged 11 commits into from
Oct 31, 2024
Merged

Conversation

insipx
Copy link
Contributor

@insipx insipx commented Oct 30, 2024

this calls the OnConnectionLost on all errors that might happen from grpc. This should let messagekit handle the error however it needs to

Copy link

changeset-bot bot commented Oct 30, 2024

🦋 Changeset detected

Latest commit: 52b3e7e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@xmtp/grpc-api-client Patch
@xmtp/bot-kit-pro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@insipx insipx requested a review from humanagent as a code owner October 31, 2024 19:13
@rygine rygine force-pushed the insipx/fix-on-connection-lost branch from 80aee01 to 52b3e7e Compare October 31, 2024 21:10
@rygine rygine merged commit f061f03 into main Oct 31, 2024
2 checks passed
@rygine rygine deleted the insipx/fix-on-connection-lost branch October 31, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants