Update block to deny and add implicit consent for sending messages #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rygine
reviewed
Nov 1, 2023
rygine
reviewed
Nov 1, 2023
| @@ -114,7 +114,7 @@ export class Conversation { | |||
| } | |||
| } | |||
|
|
|||
| async consentState(): Promise<"allowed" | "blocked" | "unknown"> { | |||
| async consentState(): Promise<"allowed" | "denied" | "unknown"> { | |||
There was a problem hiding this comment.
i see this string union type defined twice (here and in index.ts). think it's worth it to create 1 type and reference that instead?
rygine
approved these changes
Nov 1, 2023
|
🎉 This PR is included in version 1.18.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the items outlined here: https://github.com/orgs/xmtp/discussions/49#discussioncomment-7429217
Changes the word blocked to denied and adds implicit consent for sending a message to a conversation with unknown consent.