Adds custom policy type, fixes invalid policy error #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexrisch this pr should fix the invalid policy errors (tested by updating from old version and adding a new metadata field). Also "all members" now has remove member function as admin only. Existing groups before this update will now return "custom_policy" as their policy type since they have a remove member permission that is "allow" for all members. |
cameronvoell
force-pushed
the
cv/invalid-permission-refactor-errors
branch
from
95a33d7 to
74ddcf1
Compare
nplasterer
approved these changes
Jun 25, 2024
|
🎉 This PR is included in version 1.34.0-beta.17 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to xmtp/libxmtp#867